Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to codecov uploads #5173

Closed
yurishkuro opened this issue Feb 6, 2024 · 1 comment · Fixed by #5411
Closed

Add retries to codecov uploads #5173

yurishkuro opened this issue Feb 6, 2024 · 1 comment · Fixed by #5411
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Feb 6, 2024

Many of our CI workflows upload code coverage to codecov, but it has not always been very reliable. It's especially annoying when the upload fails after an expensive e2e test like Elasticsearch.

Proposal

Add retries around codecov uploads. I believe there are some ready to use GH actions that can wrap another action with retries.

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Feb 6, 2024
@prakrit55
Copy link
Contributor

I would like to work on it

yurishkuro added a commit that referenced this issue May 3, 2024
## Which problem is this PR solving?
- Objective is to cut down on the number of CI failures that are often
due to codecov uploads failing
- Resolves #5173
- Supersedes and closes #5184

## Description of the changes
- Add a new helper action which encapsulates defining a CODECOV token
and uploading with retries

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
Pushkarm029 pushed a commit to Pushkarm029/jaeger that referenced this issue May 4, 2024
## Which problem is this PR solving?
- Objective is to cut down on the number of CI failures that are often
due to codecov uploads failing
- Resolves jaegertracing#5173
- Supersedes and closes jaegertracing#5184

## Description of the changes
- Add a new helper action which encapsulates defining a CODECOV token
and uploading with retries

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
2 participants