-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry in upload codecov actions #5184
Add retry in upload codecov actions #5184
Conversation
Signed-off-by: Griffin <prakritimandal611@gmail.com>
.github/workflows/ci-cassandra.yml
Outdated
- name: Upload coverage to codecov | ||
uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2 # v3.1.3 | ||
|
||
- name: Retry action for codecov uploads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name of the step is still Upload coverage to codecov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5184 +/- ##
==========================================
- Coverage 95.67% 94.05% -1.63%
==========================================
Files 325 331 +6
Lines 18639 19156 +517
==========================================
+ Hits 17833 18017 +184
- Misses 647 957 +310
- Partials 159 182 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Griffin <prakritimandal611@gmail.com>
## Which problem is this PR solving? - Objective is to cut down on the number of CI failures that are often due to codecov uploads failing - Resolves jaegertracing#5173 - Supersedes and closes jaegertracing#5184 ## Description of the changes - Add a new helper action which encapsulates defining a CODECOV token and uploading with retries ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Which problem is this PR solving?
Fixes: #5173
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test