Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin the version of Delve in the debug images #5850

Closed
yurishkuro opened this issue Aug 14, 2024 · 1 comment · Fixed by #5852
Closed

Pin the version of Delve in the debug images #5850

yurishkuro opened this issue Aug 14, 2024 · 1 comment · Fixed by #5852
Labels
docker Pull requests that update Docker code good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

In docker/debug/Dockerfile we are always installing the latest delve

go install github.com/go-delve/delve/cmd/dlv@latest

A better solution (for repeatable builds) is to have a local go.mod file that can be managed by the bots for version upgrades, similar to how we do it for tools in internal/tools.
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Aug 14, 2024
@dosubot dosubot bot added docker Pull requests that update Docker code go labels Aug 14, 2024
@hellspawn679 hellspawn679 mentioned this issue Aug 15, 2024
Merged
4 tasks
@yurishkuro yurishkuro mentioned this issue Aug 17, 2024
Merged
yurishkuro added a commit that referenced this issue Aug 17, 2024
@renovate-bot @yurishkuro
Add fake import to ensure delve dependency is kept (#5857)
93ecc9e 
Follow-up fix for #5852 and #5850

---------

Signed-off-by: Mend Renovate <bot@renovateapp.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Copy link
Member Author

Example of bot upgrading dependency: #5858

JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this issue Aug 28, 2024
@renovate-bot @yurishkuro @JaredTan95
Add fake import to ensure delve dependency is kept (jaegertracing#5857)
33b180e 
Follow-up fix for jaegertracing#5852 and jaegertracing#5850

---------

Signed-off-by: Mend Renovate <bot@renovateapp.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker Pull requests that update Docker code good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add go.mod for Docker Debug Image hellspawn679/jaeger
1 participant
@yurishkuro