-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go.mod for Docker Debug Image #5852
Conversation
Signed-off-by: mehul gautam <mehulsharma4786@gamil.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5852 +/- ##
=========================================
+ Coverage 0 96.79% +96.79%
=========================================
Files 0 342 +342
Lines 0 16522 +16522
=========================================
+ Hits 0 15993 +15993
- Misses 0 341 +341
- Partials 0 188 +188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
docker/debug/Dockerfile
Outdated
COPY go.mod go.sum /go/src/debug-delve/ | ||
WORKDIR /go/src/debug-delve | ||
# Download dependencies (including Delve) | ||
RUN go mod download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want this command to only run before L20, inside the if statement (otherwise it might fail on unsupported architectures)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, you can do cd /go/src/debug-delve && go mod download
instead of using WORKDIR
please write proper/descriptive PR title |
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Follow-up fix for jaegertracing#5852 and jaegertracing#5850 --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test