Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Dump storage docker logs in Github CI if e2e test failed #5433

Merged
merged 3 commits into from
May 8, 2024

Conversation

james-ryans
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Add more visibility to CI workflows by dumping related storage docker logs if the tests failed.
  • Made changes to Cassandra, Elasticsearch, and Opensearch.

How was this change tested?

  • Not tested, unable to test locally.

Checklist

Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 8, 2024
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (b6c7242) to head (a2918f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5433   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files         346      346           
  Lines       16951    16951           
=======================================
  Hits        16054    16054           
  Misses        695      695           
  Partials      202      202           
Flag Coverage Δ
badger_v1 10.28% <ø> (ø)
badger_v2 6.39% <ø> (ø)
cassandra-3.x-v1 18.78% <ø> (ø)
cassandra-3.x-v2 6.14% <ø> (ø)
cassandra-4.x-v1 18.78% <ø> (ø)
cassandra-4.x-v2 6.11% <ø> (?)
elasticsearch-5.x 5.74% <ø> (+0.01%) ⬆️
elasticsearch-6.x 5.74% <ø> (?)
elasticsearch-7.x 5.73% <ø> (ø)
elasticsearch-8.x 5.74% <ø> (ø)
grpc_v1 12.61% <ø> (+0.02%) ⬆️
grpc_v2 11.35% <ø> (ø)
kafka 9.99% <ø> (ø)
opensearch-1.x 5.73% <ø> (ø)
opensearch-2.x 5.74% <ø> (+0.01%) ⬆️
unittests 91.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro marked this pull request as ready for review May 8, 2024 16:41
@yurishkuro yurishkuro requested a review from a team as a code owner May 8, 2024 16:41
@yurishkuro yurishkuro requested a review from albertteoh May 8, 2024 16:41
@yurishkuro yurishkuro merged commit 12aa9da into jaegertracing:main May 8, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants