Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Dump storage docker logs in Github CI if e2e test failed #5433

Merged
merged 3 commits into from
May 8, 2024
Merged

[v2] Dump storage docker logs in Github CI if e2e test failed #5433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09250b5
dump storage docker logs if test failed
james-ryans May 8, 2024
5858824
fix wrong echo text to GITHUB_OUTPUT
james-ryans May 8, 2024
a2918f5
return cid to the func called
james-ryans May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci-cassandra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ jobs:
go-version: 1.22.x

- name: Run cassandra integration tests
id: test-execution
run: bash scripts/cassandra-integration-test.sh ${{ matrix.version.image }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }}

- name: Output Cassandra logs
run: docker logs ${{ steps.test-execution.outputs.cid }}
if: ${{ failure() }}

- name: Upload coverage to codecov
uses: ./.github/actions/upload-codecov
with:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ci-elasticsearch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,13 @@ jobs:
- uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0

- name: Run elasticsearch integration tests
id: test-execution
run: bash scripts/es-integration-test.sh ${{ matrix.version.distribution }} ${{ matrix.version.image }}

- name: Output Elasticsearch logs
run: docker logs ${{ steps.test-execution.outputs.cid }}
if: ${{ failure() }}

- name: Upload coverage to codecov
uses: ./.github/actions/upload-codecov
with:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ci-opensearch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,13 @@ jobs:
- uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0

- name: Run opensearch integration tests
id: test-execution
run: bash scripts/es-integration-test.sh ${{ matrix.version.distribution }} ${{ matrix.version.image }}

- name: Output Opensearch logs
run: docker logs ${{ steps.test-execution.outputs.cid }}
if: ${{ failure() }}

- name: Upload coverage to codecov
uses: ./.github/actions/upload-codecov
with:
Expand Down
3 changes: 1 addition & 2 deletions scripts/cassandra-integration-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,13 @@ setup_cassandra() {
local tag=$1
local image=cassandra
local params=(
--rm
--detach
--publish 9042:9042
--publish 9160:9160
)
local cid
cid=$(docker run "${params[@]}" "${image}:${tag}")
echo "${cid}"
echo "${cid}" >> "$GITHUB_OUTPUT"
yurishkuro marked this conversation as resolved.
Show resolved Hide resolved
}

teardown_cassandra() {
Expand Down
4 changes: 2 additions & 2 deletions scripts/es-integration-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ setup_es() {

local cid
cid=$(docker run "${params[@]}" "${image}:${tag}")
echo "${cid}"
echo "${cid}" >> "$GITHUB_OUTPUT"
}

setup_opensearch() {
Expand All @@ -57,7 +57,7 @@ setup_opensearch() {
)
local cid
cid=$(docker run "${params[@]}" "${image}:${tag}")
echo "${cid}"
echo "${cid}" >> "$GITHUB_OUTPUT"
}

wait_for_storage() {
Expand Down
Loading