Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling binaries with spaces in the path #259

Closed
jamesmcm opened this issue Mar 23, 2024 · 1 comment
Closed

Fix handling binaries with spaces in the path #259

jamesmcm opened this issue Mar 23, 2024 · 1 comment

Comments

@jamesmcm
Copy link
Owner

It seems the addition of shellexpand broke the handling of spaces in the path for the exec command.

e.g.

$ vopono exec --user plex --custom ~/Downloads/wg-RO-9.conf --protocol wireguard --provider custom --custom-port-forwarding protonvpn /usr/lib/plexmediaserver/Plex\ Media\ Server

Now fails.
jamesmcm added a commit that referenced this issue Mar 28, 2024
@jamesmcm
Fix command parsing, add env var, host entry
5eea56e 
- Fixes handling of target applications with spaces in the name. This
  applies for the target application and also postup and predown host
  scripts. Fixes issue #259
- Add argument handling for postup and predown scripts, so these can be
  passed arguments now.
- Add `vopono.host` entry to the hosts file in the network namespace
  with the `$VOPONO_HOST_IP` if `--allow-host-access` is used. This
  allows you to access services on the host at `http://vopono.host:80`
  etc. from inside the network namespace. Addresses issue #262
- Add `$VOPONO_FORWARDED_PORT` environment variable if
  `--port-forwarding` or `--custom-port-forwarding` are used for
  provider port forwarding. Addresses issue #260
- Added details on Plex port forwarding configuration to the
  USERGUIDE.md
@jamesmcm jamesmcm mentioned this issue Mar 28, 2024
Merged
@jamesmcm
Copy link
Owner Author

Fixed in #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesmcm