Fix command parsing, add env var, host entry #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes handling of target applications with spaces in the name. This applies for the target application and also postup and predown host scripts. Fixes issue #259 - Add argument handling for postup and predown scripts, so these can be passed arguments now. - Add `vopono.host` entry to the hosts file in the network namespace with the `$VOPONO_HOST_IP` if `--allow-host-access` is used. This allows you to access services on the host at `http://vopono.host:80` etc. from inside the network namespace. Addresses issue #262 - Add `$VOPONO_FORWARDED_PORT` environment variable if `--port-forwarding` or `--custom-port-forwarding` are used for provider port forwarding. Addresses issue #260 - Added details on Plex port forwarding configuration to the USERGUIDE.md
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vopono.hostentry to the hosts file in the network namespace with the$VOPONO_HOST_IPif--allow-host-accessis used. This allows you to access services on the host athttp://vopono.host:80etc. from inside the network namespace. Addresses issue Accessing services outside of namespace from within the namespace #262$VOPONO_FORWARDED_PORTenvironment variable if--port-forwardingor--custom-port-forwardingare used for provider port forwarding. Addresses issue Pass forwarded port to POSTUP script if port forwarding (Plex) #260