Implement a basic keybinding collision checker. (ToDo list #337) #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrram
force-pushed
the
basic-keybind-collision-checker
branch
from
5e1fc19
to
c1fcc73
Compare
|
Wow! This was quick! Thanks for the PR. I will complete this review shortly. Note for @jarun: Please document this in the Wiki Advanced... |
jarun
requested changes
Oct 10, 2019
annagrram
force-pushed
the
basic-keybind-collision-checker
branch
3 times, most recently
from
7cbcbc3
to
9b32da1
Compare
jarun
reviewed
Oct 10, 2019
jarun
reviewed
Oct 10, 2019
annagrram
force-pushed
the
basic-keybind-collision-checker
branch
2 times, most recently
from
9ab7ca4
to
2fe8960
Compare
annagrram
force-pushed
the
basic-keybind-collision-checker
branch
from
2fe8960
to
27e74e1
Compare
|
Thank you for your contribution! |
|
@annagrram could you make some time to add the the patch for coreutils v8.31 to advcmpv? |
|
Sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.