[CS2] 2.0.0-beta1 docs #4494
Merged
[CS2] 2.0.0-beta1 docs #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn tables, avoid hack of blockquoted code blocks
…s variant for comments font
…aking Changes section below Literate CoffeeScript section
Merged
lydell
approved these changes
Apr 10, 2017
Cakefile
Outdated
| try | ||
| return hljs.highlight(lang, str).value | ||
| catch ex | ||
| return '' # No syntax highlighting |
There was a problem hiding this comment.
This line should be dedented once according to the documentation you linked to.
There was a problem hiding this comment.
Good catch! Probably didn’t matter because highlight.js never threw an exception, but can’t hurt to get it right.
|
So . . . release beta1 now (or rather, after I merge the 1.12.5 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rawgit.com/GeoffreyBooth/coffeescript/2.0.0-beta1-docs/docs/v2/index.html
I’ve updated the 2 docs to reflect:
getorsetkeywords or function calls #4484: Throw and error on ambiguousgetorsetfunction callsI’ve removed Marked in favor of Markdown-It, so now we only have one Markdown parsing library across the project for both documentation and Literate CoffeeScript support. I also added syntax highlighting back in for the non-editable code blocks.
The release date for 2.0.0-beta1 is a wild guess that I expect we’ll revise as part of that actual release; I just thought these changes, especially the Markdown library swap, were significant enough to warrant their own PR and review.
On a side note, should we release beta1 now or wait for #4493 to land?
Preview of docs in this PR: https://rawgit.com/GeoffreyBooth/coffeescript/2.0.0-beta1/docs/v2/