[CS2] 2.0.0-beta1 #4499
Merged
[CS2] 2.0.0-beta1 #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FY=false, because Closure Compiler throws an error on our current code; see google/closure-compiler-js#59
|
Did you accidentally submit this PR against |
|
This is why I need you. |
|
I couldn't find the change log from alpha1 to beta1? |
|
https://rawgit.com/GeoffreyBooth/coffeescript/2.0.0-beta1/docs/v2/ I put 1.12.5 between 2.0.0-alpha1 and beta1 to imply that beta1 includes the changes from 1.12.5. I think it’s clear enough? |
|
No Babel addition, please — and it's fine to leave unminified temporarily, but it would be lovely to find a minifier that works for these sorts of things. |
|
@jashkenas Agreed, though remember that we switched from Uglify to Closure because Uglify didn’t support ES2015. Hopefully the Closure team fixes the issue before we release 2.0.0, or I guess the next best option is Babili. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #4494, here’s a possible release of 2.0.0-beta1. In this PR:
2.The browser build is unminified. This isn’t intentional; the Closure Compiler chokes on our latest build. I suspect it’s because it doesn’t fully support ES destructuring syntax, and that’s an ES feature we use rather extensively in the compiler codebase.
So I guess our options are to either release it unminified, at least until Closure Compiler supports whatever is causing it to choke; find yet another minifier; or add a Babel transpilation step before minification. I’m loathe to add Babel; what do you all think? I’m hoping that maybe an unminified browser compiler is fine for the 2.0.0 beta releases, and hopefully Closure Compiler will be patched before we release 2.0.0 out of beta.
The other consideration worth discussing is whether we should wait until #4493 is merged in before releasing this. I’m leaning toward releasing beta1 now and beta2 when #4493 is ready. Any thoughts?