Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run patch-package only on development (test+publish) #2972

Closed
wants to merge 1 commit into from
Closed

Run patch-package only on development (test+publish) #2972

wants to merge 1 commit into from

Conversation

iglosiggio
Copy link

I'm not sure this is the correct fix (don't have the setup to do js development here) but it looks like a viable direction.

This should help with #2967 #2968 #2969 #2970 #2971

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.024% when pulling becb32a on iglosiggio:patch-1 into 66ee70d on jashkenas:master.

@jgonggrijp
Copy link
Collaborator

Thanks for the patch and sorry for the trouble I have caused. I'm going to hotfix this first by simply throwing the postinstall script out of the package.json; I'm not sure what is the right place to run patch-package yet, but it is not required for end users in any case.

jgonggrijp added a commit that referenced this pull request Sep 23, 2022
This broke much more stuff than I expected.

Ref #2967 #2968 #2969 #2970 #2971 #2972 #2973 #2974
@jgonggrijp
Copy link
Collaborator

I chose a slightly different, but similar approach: run it before building the annotated sources, rather than before running the tests. That's because the patched package is docco, which we use for the annotated sources. Thanks again for the fast action!

@jgonggrijp jgonggrijp closed this Sep 23, 2022
@jgonggrijp
Copy link
Collaborator

(Oh, and also #2974 was merged first by @jashkenas, while I was doing the same thing locally.)

@iglosiggio
Copy link
Author

I chose a slightly different, but similar approach: run it before building the annotated sources, rather than before running the tests. That's because the patched package is docco, which we use for the annotated sources. Thanks again for the fast action!

Thank you for your swift resolution of the issue! <3

@iglosiggio iglosiggio deleted the patch-1 branch September 24, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants