Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for broken builds #2974

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Hotfix for broken builds #2974

merged 1 commit into from
Sep 23, 2022

Conversation

paulsmithkc
Copy link
Contributor

@paulsmithkc paulsmithkc commented Sep 23, 2022

patch-package is a dev dependency and should not be required by users of underscore.js

This hotfix removes the postinstall script which is causing multiple build failures across the ecosystem.

See #2967, #2968, #2969, #2970, #2971, #2973

patch-package is a dev dependency and should not be required by users of underscore.js

This hotfix removes the postinstall script which is causing multiple build failures across the ecosystem.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.024% when pulling 2edcdc1 on paulsmithkc:patch-1 into 66ee70d on jashkenas:master.

@paulsmithkc paulsmithkc changed the title Hostfix for broken builds Hotfix for broken builds Sep 23, 2022
@paulsmithkc
Copy link
Contributor Author

@jashkenas bump

@jashkenas jashkenas merged commit 4eb6894 into jashkenas:master Sep 23, 2022
@jcowley
Copy link

jcowley commented Sep 23, 2022

Thank you!

@jashkenas
Copy link
Owner

Will publish as 1.13.6 in a few minutes, hang tight.

@jgonggrijp
Copy link
Collaborator

@jashkenas I think I outran you.

@jgonggrijp
Copy link
Collaborator

With publishing to NPM, at least.

@jgonggrijp
Copy link
Collaborator

I'm preparing a website update now, please let me know where you stand.

@jashkenas
Copy link
Owner

Thanks for jumping in @jgonggrijp — I'll leave things in your hands as to avoid crossing wires. (npm had me locked out on this new laptop, so thanks for pushing the button)

@jgonggrijp
Copy link
Collaborator

jgonggrijp commented Sep 23, 2022

Alright I'll finish the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants