Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning for Version 2.0 #122

Open
jasonday opened this issue Jul 31, 2017 · 10 comments
Open

Planning for Version 2.0 #122

jasonday opened this issue Jul 31, 2017 · 10 comments
Assignees
Milestone

Comments

@jasonday
Copy link
Owner

jasonday commented Jul 31, 2017

Potential list of to-dos:

  1. Retest $iframe.ready() and $iframe.load browser support
    1. Remove setTimeouts (potential) Remove First setTimeout #85
  2. Match options to be in the same format ("tense")
  3. Add complete event ( add complete event #54 ); likely dependent on # 1 above
  4. Universal module export as 'universal module' #121
  5. or remove jQuery dependencies?

@oculus42 other potential changes?

@jasonday jasonday self-assigned this Jul 31, 2017
@jasonday jasonday changed the title Retest $iframe.ready() and $iframe.load browser support Planning for Version 2.0 Aug 8, 2017
@jasonday jasonday added this to the v2.0 milestone Aug 8, 2017
@oculus42
Copy link
Collaborator

I had crazy visions of making the various features into modules that could be loaded.

@oculus42
Copy link
Collaborator

Additional question: Do you want to set a browser support limit for 2.0?

@jasonday
Copy link
Owner Author

@oculus42 - depends on what we want to do, but yeah - probably

@jasonday
Copy link
Owner Author

jasonday commented Nov 10, 2017

potential option for event after print, but needs thorough testing:
https://www.tjvantoll.com/2012/06/15/detecting-print-requests-with-javascript/

And because window.matchMedia('print'); fires twice in chrome, this may not be a valid option (and does it fire twice in chrome consistently?)

@jasonday
Copy link
Owner Author

Add integration with a pdf generation library.

@Geoffry304
Copy link

Do you have any idea when the pdf generation would be ready? :)

@LucasHill
Copy link

I'm using printThis this in an ember addon and soon-ish Ember will be removing jquery. So removing the jquery dependency would be amazing. Thanks for the great work.

@jasonday
Copy link
Owner Author

jasonday commented Aug 27, 2018 via email

@oculus42
Copy link
Collaborator

Added a 2.0 project: https://github.com/jasonday/printThis/projects/1

@ryanlin1986
Copy link

Vote for #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants