Remove First setTimeout #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use single quotes in the outer strings to eliminate most of the backslashes. and improve readability.
Rather than finding it again, we can always keep the reference to the iframe, no matter which way it was created.
Using onload in the various forms should work. Tested in Chrome, Firefox, IE10… Will test more as time permits.
Testing in Firefox, Chrome, Safari, IE 8+
|
I'm going to see if I can rework more timeouts, so hold off on merging, but code review is appreciated. |
Same fix asPR 90 for #57
Solves problems inlining the script.
|
Looks interesting. I'd also recommend putting your name in as another author. |
Try to implement postMessage to the child iframe to allow a proper print “callback” because the print action pauses scripting in the iframe, but not outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in Firefox, Chrome, Safari, IE 8+