Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add case for arm architecture to work on RP2 #29

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

codefoster
Copy link
Contributor

@jasongin, I added the line like you suggested and just tested it on my RP2. Worked great. Thank you. Here's a PR.

@jasongin jasongin merged commit 5f90ef8 into jasongin:develop Feb 7, 2017
@codefoster
Copy link
Contributor Author

@jasongin, I'm not certain this is working as expected. When I use it on my RP2, I get the 6l (that's a lowercase L) version and not 7l as I would expect. I don't have time to look into the reason right now, but the process.config.variables.arm_version might be incorrect.

@jasongin
Copy link
Owner

See these related node issues:

So, it's a bug in node, and I think not one that I can reasonably work around. But it should have little or no impact in practice, since the arm v6 binary should run fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants