-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api to get arm architecture of the binary as in the download page... #7803
Comments
If you don't mind using child processes, you could always use |
Also, none of |
Lines 266 to 277 in 5aac4c4
But there is something strange, node.js
The output from
But on distribution packaged one....
|
cc @nodejs/build maybe? |
I believe we do that to maximize compatibility with boards that are only nominally ARMv7-compatible, like the rpi1. Code quality-wise it shouldn't matter too much because V8 detects the architecture at run-time. OpenSSL may be negatively affected but I'm not 100% sure about that, I think it does run-time feature detection as well. |
FYI:
|
This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that. |
I'm still interested on this feature. In fact, at prebuild/prebuild#174 we were discussing about using |
Re-opened as requested. |
Thank you. |
Same question I just posted to #4531: Is anyone in a good position to move this issue forward? Or should we add a |
I wonder if there would be resistance to adding more stuff to |
FYI the arm version should be fixed for Node 10+ since we're properly cross compiling with our own custom toolchain now and it's working really well. That's not the focus of this issue but it's relevant to some of the discussion. I think I'd be OK with a |
Wouldn't an easy solution be to make |
@BridgeAR ... there are modules in the ecosystem that completely override the value of |
Do you know the reason they override |
The fact that `process.config` is mutable has long made it unreliable when it really should just work. Start the process of deprecating the ability to change it. Fixes: nodejs#7803 Signed-off-by: James M Snell <jasnell@gmail.com>
I couldn't find any api to get the architecture of the binary itself,
process.arch
just givesarm
uname -a
would give for the host.. not the binarynode --v8-options
givestarget arm v7..
, and a lot of output..I want it for the the binary as it is on the download page..
arm64
armv6l
armv7l
I dumped and greped the
process
object and found..process.config.variables.arm_version
among others...Checking the api doc for
process.config
says it is not read-only and gives some warning about some packages changing it..Could and api be added for this, or should we just parse this form
process.config.variables.arm_*
or--v8-options
or any other suggestions..The text was updated successfully, but these errors were encountered: