don't localize tag attributes values #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since latest commits,
DecimalField
(andFloatField
I guess) havemin
,max
andstep
properties. Step property use thedecimal_place
attribute.However, attribute values are rendered with the template engine. And if settings
USE_L10N=True
, any values would be localized by default.As a consequence, with the French language enabled, we would got a HTML tag attribut
step=0,01
. With Chrome at least, this could be invalid and round the step to integer!I think that we should do the same thing for any attributes: force them to don't be localized.
However, a special note should be throw to other users implementing their own
attrs.html
template because they may update it too (if using l10n and applying the default behaviour, which is to localize any values).Thanks