Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't localize tag attributes values #156

Merged
merged 1 commit into from
Jul 30, 2015
+11 −1
Merged

don't localize tag attributes values #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion floppyforms/templates/floppyforms/attrs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
which is just ugly in the resulting HTML. The tests will fail if you do so
by accident :)

{% endcomment %}{% load floppyforms_internals %}{% for name, value in attrs.items %} {{ name }}{% if not value|istrue %}="{{ value }}"{% endif %}{% endfor %}
{% endcomment %}{% load floppyforms_internals l10n %}{% for name, value in attrs.items %} {{ name }}{% if not value|istrue %}="{% localize off %}{{ value }}{% endlocalize %}"{% endif %}{% endfor %}
10 changes: 10 additions & 0 deletions tests/test_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import datetime
import decimal
import os
import sys

Expand Down Expand Up @@ -1373,3 +1374,12 @@ def test_attrs_with_multiple_values(self):
# disabled shouldn't have a value
self.assertTrue(' disabled' in rendered)
self.assertTrue(' disabled=' not in rendered)

def test_attrs_not_localized(self):

# We should got 0.01, not 0,01.
with override_settings(USE_L10N=True, LANGUAGE_CODE='fr-fr'):
rendered = self.render_attrs({'step': decimal.Decimal('0.01')})
self.assertTrue(rendered in [
' step="0.01"',
])