Fix ReadSymbols in a Module that is already created #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r example: var symbolReader = portablePdbReaderProvider.GetSymbolReader(asm.image, stream); asm.image.ReadSymbols(symbolReader); method.debug_info has a list, but it's empty, so it wasn't entering in the if, but it should, maybe we should change de if to method.debug_info == null || method.debug_info.count = 0.
|
Hi @thaystg, good to see you here. Could you add a unit test that reproduces your scenario? |
Done!!! :) |
|
@jbevain could you please merge and generate a new nuget version? We need this for wasm debug. |
|
Thanks! |
|
@thaystg the fix shipped in 0.11.3. Thanks! |
marek-safar
added a commit
to dotnet/cecil
that referenced
this pull request
Oct 8, 2020
)" This reverts commit 191f9fc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to use ReadSymbols in a Module that is already created, for example:
method.debug_info has a list, but it's empty, so it wasn't entering in the if, but it should, maybe we should change the if to method.debug_info == null || method.debug_info.count = 0.
Relates to this PR: dotnet/runtime#40690