Introduce extra indirection in ObjectBuilder$ModuleFinder
#426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason this is done is to allow ObjectBuilder$ModuleFinder the class to be loaded and initialized even when JBoss Modules is not present on the classpath. The ultimate goal of this is to allow for Quarkus to substitute the method when building a native image and fix the problem mentioned in quarkusio/quarkus#33318 (comment)
jamezp
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason this is done is to allow
ObjectBuilder$ModuleFinderthe class to beloaded and initialized even when JBoss Modules
is not present on the classpath.
The ultimate goal of this is to allow for Quarkus
to substitute the method when building a native
image and fix the problem mentioned in
quarkusio/quarkus#33318 (comment)