Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/cli): relative paths, empty slides, and tests #223

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Conversation

jeertmans
Copy link
Owner

This fixes two issues:

  1. Empty slides are now reported as error, to prevent indexing error;
  2. Changing the folder path will now produce an absolute path to slides, which was not the case before and would lead to a "file does not exist error".

A few tests were also added to cover those

This fixes two issues:

1. Empty slides are now reported as error, to prevent indexing error;
2. Changing the folder path will now produce an absolute path to slides, which was not the case before and would lead to a "file does not exist error".

A few tests were also added to cover those
@jeertmans jeertmans added bug Something isn't working ci Continous Integration (tests, lints, checks, ...) lib Related to the library (a.k.a. module) labels Jul 24, 2023
@jeertmans jeertmans temporarily deployed to github-pages July 24, 2023 11:04 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 75.67% and project coverage change: +18.31 🎉

Comparison is base (2b6240c) 39.97% compared to head (fc99f44) 58.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #223       +/-   ##
===========================================
+ Coverage   39.97%   58.29%   +18.31%     
===========================================
  Files          14       14               
  Lines        1691     1712       +21     
===========================================
+ Hits          676      998      +322     
+ Misses       1015      714      -301     
Impacted Files Coverage Δ
manim_slides/wizard.py 37.39% <50.00%> (+37.39%) ⬆️
manim_slides/config.py 74.71% <82.60%> (+14.32%) ⬆️
manim_slides/present.py 56.37% <83.33%> (+29.38%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pre-commit-ci pre-commit-ci bot temporarily deployed to github-pages July 24, 2023 11:54 Inactive
@jeertmans jeertmans merged commit 529a6c5 into main Jul 24, 2023
24 checks passed
@jeertmans jeertmans deleted the tests branch July 24, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continous Integration (tests, lints, checks, ...) lib Related to the library (a.k.a. module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant