Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/cli): relative paths, empty slides, and tests #223

Merged
merged 4 commits into from
Jul 24, 2023
Merged

fix(lib/cli): relative paths, empty slides, and tests #223

merged 4 commits into from
Jul 24, 2023

Commits on Jul 24, 2023

  1. fix(lib/cli): relative paths, empty slides, and tests 

    This fixes two issues:

1. Empty slides are now reported as error, to prevent indexing error;
2. Changing the folder path will now produce an absolute path to slides, which was not the case before and would lead to a "file does not exist error".

A few tests were also added to cover those
    @jeertmans
    jeertmans committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    fdb2a9b View commit details
    Browse the repository at this point in the history

  2. fix(lib): fix from_file, remove useless field, and more

    @jeertmans
    jeertmans committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    cf0a7b7 View commit details
    Browse the repository at this point in the history

  3. chore(tests): remove print

    @jeertmans
    jeertmans committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    91dd281 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    fc99f44 View commit details
    Browse the repository at this point in the history