Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only use HLS for live tv - otherwise use progressive mkv #1440

Closed
wants to merge 1 commit into from
Closed

only use HLS for live tv - otherwise use progressive mkv #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1448,7 +1448,8 @@ public long getDuration() {
public long getBufferedPosition() {
long bufferedPosition = -1;

if (hasInitializedVideoManager())
// FIXME handle live tv buffered position and position while paused
if (!isLiveTv() && hasInitializedVideoManager())
bufferedPosition = mVideoManager.getBufferedPosition();

if (bufferedPosition < 0)
Expand Down
59 changes: 40 additions & 19 deletions app/src/main/java/org/jellyfin/androidtv/util/profile/ExoPlayerProfile.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,29 +45,50 @@ class ExoPlayerProfile(
init {
name = "AndroidTV-ExoPlayer"

transcodingProfiles = arrayOf(
// MP4 video profile
TranscodingProfile().apply {
type = DlnaProfileType.Video
context = EncodingContext.Streaming
container = ContainerTypes.MP4
videoCodec = buildList {
if (deviceHevcCodecProfile.ContainsCodec(CodecTypes.HEVC, ContainerTypes.MP4)) add(CodecTypes.HEVC)
add(CodecTypes.H264)
}.joinToString(",")
audioCodec = arrayOf(CodecTypes.AAC, CodecTypes.MP3).joinToString(",")
protocol = "hls"
minSegments = 1
copyTimestamps = false
},
// MP3 audio profile
TranscodingProfile().apply {
transcodingProfiles = buildList {
// FIXME use HLS for all transcoded video
// on seeking, the server builds the stream starting at the previous key-frame
// exoplayer (2.16.1) only supports frame-accurate seeking
// it will assume the seek position is accurate despite the server starting the stream
// earlier than the position. This breaks subtitle sync and loops the last few seconds
// of the media. Because of this, only use HLS for live-tv.

if (isLiveTV) {
// FMP4 HLS profile for live tv
add(TranscodingProfile().apply {
type = DlnaProfileType.Video
context = EncodingContext.Streaming
container = ContainerTypes.MP4
videoCodec = buildList {
if (deviceHevcCodecProfile.ContainsCodec(CodecTypes.HEVC, ContainerTypes.MP4)) add(CodecTypes.HEVC)
add(CodecTypes.H264)
}.joinToString(",")
audioCodec = arrayOf(CodecTypes.AAC, CodecTypes.MP3).joinToString(",")
protocol = "hls"
minSegments = 1
})
} else {
// MKV profile for everything else
add(TranscodingProfile().apply {
type = DlnaProfileType.Video
context = EncodingContext.Streaming
container = "mkv"
videoCodec = buildList {
if (deviceHevcCodecProfile.ContainsCodec(CodecTypes.HEVC, ContainerTypes.MKV)) add(CodecTypes.HEVC)
add(CodecTypes.H264)
}.joinToString(",")
audioCodec = arrayOf(CodecTypes.AAC, CodecTypes.MP3).joinToString(",")
protocol = "http"
copyTimestamps = true
})
}
add(TranscodingProfile().apply {
type = DlnaProfileType.Audio
context = EncodingContext.Streaming
container = CodecTypes.MP3
audioCodec = CodecTypes.MP3
}
)
})
}.toTypedArray()

directPlayProfiles = buildList {
// Video direct play
Expand Down