only use HLS for live tv - otherwise use progressive mkv #1440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getBufferedPosition()
that excludes live-tv. The logic for getting the current position when playing live tv is kinda broken, especially if the player is paused and then resumed.Issues
using mkv again should resolve 0.13beta1 track transcoding bug #1410 though I'm not sure about live-tv contexts
after seeking using HLS, the video would be slightly early but the timestamp wouldn't reflect it.
This caused:
According to ffmpeg docs, the flag
-noaccurate_seek
, which jellyfin uses, supplies a stream starting at the key-frame prior to the requested timestamp. This is incompatible with exoplayer's frame-accurate seeking.The ffmpeg docs (https://trac.ffmpeg.org/wiki/Seeking):
To resolve this and use HLS in contexts that allow seeking, the version of exoplayer we use will need to support
SeekParameters
for HLS. As far as I can tell, the flag we'd use isSeekParameters.PREVIOUS_SYNC
The relevant issue is here:
Support key-frame accurate seeking in HLS google/ExoPlayer#2882
And here is the merged PR that should allow this once the next exoplayer release comes out:
Implements SeekParameters.*_SYNC variants for HLS google/ExoPlayer#9536
Notes