Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle rendering optimization #1455

Merged

Conversation

mueslimak3r
Copy link
Member

@mueslimak3r mueslimak3r commented Feb 19, 2022

Changes

  • render and clear each subtitle event once

Issues

  • each subtitle event could be rendered many times (every 50ms), and the same could happen for clearing

Notes
best tested direct playing with either backend, or with libvlc if transcoding
pending jellyfin/jellyfin#7338 or another solution like #1440, externally rendered subs won't be in sync with a transcoded video with exoplayer

@mueslimak3r mueslimak3r force-pushed the subtitle-rendering-optimization branch from 0675cdf to c985df9 Compare February 19, 2022 10:22
@mueslimak3r mueslimak3r marked this pull request as draft February 19, 2022 10:54
@mueslimak3r mueslimak3r marked this pull request as ready for review February 19, 2022 11:01
@nielsvanvelzen nielsvanvelzen merged commit 8424e58 into jellyfin:master Feb 20, 2022
@mueslimak3r mueslimak3r deleted the subtitle-rendering-optimization branch February 20, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants