Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home image size bug. Update all home view sections - including those previously hidden #1530

Merged
merged 21 commits into from
Dec 5, 2023
Merged

Fix home image size bug. Update all home view sections - including those previously hidden #1530

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ed55faf
Fix home image size
1hitsong Nov 22, 2023
0a7d74d
Revert "Fix home image size"
1hitsong Nov 22, 2023
35dfa54
Rework how we keep track of row item sizes
1hitsong Nov 22, 2023
142419c
Add sections to home view on update as needed
1hitsong Nov 22, 2023
a5af255
Reset focus to selected item when returning to home view
1hitsong Nov 22, 2023
06af8b2
Don't allow Roku's component reuse to mess up library fonts
1hitsong Nov 23, 2023
867667f
Add setting to match web's home sections
1hitsong Nov 23, 2023
4092519
Review Updates & Bug Fix
1hitsong Nov 25, 2023
47781b7
Fix 1st run setting
1hitsong Nov 26, 2023
f1da07e
Rename ImageSizes file to match actual use
1hitsong Nov 27, 2023
b185c08
Fix 1st time setting bug
1hitsong Nov 28, 2023
d6b5044
Fix refresh delay
1hitsong Nov 29, 2023
383e61f
Rewrite index tracking. Reduce/remove flicker.
1hitsong Dec 2, 2023
95638e5
Merge remote-tracking branch '1hitsong/unstable' into fixHomeImageSizes
1hitsong Dec 2, 2023
9cea33d
Removed dead code. Fix Latest in TV Shows posters
1hitsong Dec 2, 2023
551df56
Rename loading timer const
1hitsong Dec 2, 2023
685a623
Add valid check to contentType
1hitsong Dec 2, 2023
fe0f02b
Defensive code for if no custom prefs returned
1hitsong Dec 3, 2023
687d518
Set row item size after removing row
1hitsong Dec 3, 2023
2832799
Create short circuit if content loads faster than wait time
1hitsong Dec 3, 2023
7e7ac10
Create expected & processed counts. Hook short circuit to their values
1hitsong Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
"docs/api/**": true
},
"brightscriptcomment.addExtraAtStartAndEnd": false
}
}
5 changes: 5 additions & 0 deletions components/ImageSizes.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
namespace imageSizes
1hitsong marked this conversation as resolved.
Show resolved Hide resolved
const WIDE_POSTER = [464, 331]
const MOVIE_POSTER = [188, 331]
const MUSIC_ALBUM = [261, 331]
end namespace
4 changes: 4 additions & 0 deletions components/home/HomeItem.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ sub itemContentChanged()

' Format the Data based on the type of Home Data
if itemData.type = "CollectionFolder" or itemData.type = "UserView" or itemData.type = "Channel"
m.itemText.font.size = 35
m.itemText.height = 64
m.itemText.horizAlign = "center"
m.itemText.vertAlign = "bottom"
m.itemText.text = itemData.name
m.itemPoster.uri = itemData.widePosterURL
return
Expand Down
Loading