Fix home image size bug. Update all home view sections - including those previously hidden #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1493
This reverts commit ed55faf.
1hitsong
changed the title
cewert
requested changes
Nov 22, 2023
|
Adding this here so we don't forget... We talked in chat about using brighterscript constants or enums for the different items size arrays. There are 3 I think:
|
cewert
requested changes
Nov 25, 2023
Fix Roku component reuse bug Don't repeat loadingTimer Move ImageSizes enum to source folder Update setting text & translation Check selectedRowItem is valid and not empty
|
Current State: this addresses the review items, but the 1st load users VS upgrade user setting still isn't working correctly. I pushed my commits up so if someone has time to look at it, they can. |
cewert
reviewed
Nov 26, 2023
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
cewert
requested changes
Nov 30, 2023
There was a problem hiding this comment.
- Rows aren't being added when returning to the home page. Load the home page with an empty continue watching row, open a movie, use a client to play the movie at a random postion then pause the movie, now hit back in roku client and notice the continue watching row doesnt get created.
- The text showing the number of items for each row (1 of 9) "flickers" when the page is being updated. On prod client, the numbers mostly don't flicker at all but sometimes will flicker once. This PR flickers at least twice it seems, sometimes 3 times.
Value can be invalid for trailer libraries
cewert
requested changes
Dec 4, 2023
cewert
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes home section image size bug.
Reworks update logic so it refreshes all data (including sections that previously had no data and were hidden). This will add/remove sections as needed based on current data.
When returning to the home view, we attempt to refocus the item the user was previously focused on. If the item is gone, then the content of the row will shift left and the new item in its place will gain focus. If there is no item to take its place, then the first item in the row will gain focus. If the row no longer exists, then the rows will shift up and the new row that took its place will gain focus. If there is no row to take its place, focus will remain on the 1st item of the 1st row.
Creates a new user setting to use the web's home section arrangement. This setting is off for users who upgraded from the previous version of the client, and automatically on for new users.
Issues
Fixes #1493
Fixes #1534