Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set MediaSourceId to the correct value, not the videoId #504

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Set MediaSourceId to the correct value, not the videoId #504

merged 2 commits into from
Dec 3, 2021

Conversation

neilsb
Copy link
Member

@neilsb neilsb commented Dec 3, 2021 •
edited
Loading

Roku client is incorrectly setting the MediaSourceId to the video id

Changes

  • Set MediaSourceId to the correct value

Issues
fixes #467
fixes #397

@neilsb neilsb marked this pull request as draft December 3, 2021 17:42
@neilsb neilsb marked this pull request as ready for review December 3, 2021 17:47
crobibero
crobibero reviewed Dec 3, 2021
View reviewed changes
source/VideoPlayer.brs Outdated Show resolved Hide resolved
@anthonylavado anthonylavado merged commit 0e2d621 into jellyfin:master Dec 3, 2021
neilsb added a commit to neilsb/jellyfin-roku that referenced this pull request Jan 9, 2022
@neilsb
Revert "Merge pull request jellyfin#504 from neilsb/set-mediasourceid…
f6d9695 
…-correctly"

This reverts commit 0e2d621, reversing
changes made to d5c3165.
@neilsb neilsb mentioned this pull request Jan 9, 2022
Merged
@neilsb neilsb deleted the set-mediasourceid-correctly branch January 16, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

@anthonylavado anthonylavado anthonylavado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix proposed: App crash on when attempting to playback from Emby server app crashing to homescreen
3 participants
@neilsb @anthonylavado @crobibero