You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe The Bug
After digging into the code for some other reason (I considered adding the original framerate of the movie file to the widget) I realised, that getDisplayTranscodeFps is actually supposed to provide you a number of how many transcodings it could currently support (at least I think that is what the number is for). However I can not see that number in Jellyfin-Web (see last screenshot)
The "full" information about how much faster/how many transcodings the server could support is only returned, if originalFramerate is defined. I could not figure out looking at the code in both jellyfin-web and jellyfin-server how videoStream.AverageFrameRate is actually determined. (Idea: Maybe the jellyfin-server could always set the AverageFrameRate to the OriginalFrameRate if the AverageFrameRate can not be determined?)
It seems like a different part of the code of the webui uses stream.AverageFrameRate || stream.RealFrameRate for getting the FrameRate.
* Fix missing transcoding speed info #6198
* Use ReferenceFrameRate by default
---------
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
Describe The Bug
After digging into the code for some other reason (I considered adding the original framerate of the movie file to the widget) I realised, that
getDisplayTranscodeFps
is actually supposed to provide you a number of how many transcodings it could currently support (at least I think that is what the number is for). However I can not see that number in Jellyfin-Web (see last screenshot)jellyfin-web/src/components/playerstats/playerstats.js
Lines 199 to 211 in 39ec804
The "full" information about how much faster/how many transcodings the server could support is only returned, if
originalFramerate
is defined. I could not figure out looking at the code in both jellyfin-web and jellyfin-server howvideoStream.AverageFrameRate
is actually determined. (Idea: Maybe the jellyfin-server could always set the AverageFrameRate to the OriginalFrameRate if the AverageFrameRate can not be determined?)It seems like a different part of the code of the webui uses
stream.AverageFrameRate || stream.RealFrameRate
for getting the FrameRate.jellyfin-web/src/components/itemMediaInfo/itemMediaInfo.js
Lines 131 to 133 in 39ec804
Potential Fix
I would assume the code in the file
playerstats.js
L203 would have to be changed fromjellyfin-web/src/components/playerstats/playerstats.js
Line 203 in 39ec804
to
After changing this locally and rebuilding jellyfin-web, I was able to get the output to work as expected:
I made a PR, in case the change i suggest is correct: #6199
(I also believe that maybe it might be useful in general to add the framerate as its own line/information to
jellyfin-web/src/components/playerstats/playerstats.js
Line 223 in c4d0c42
Steps To Reproduce
Expected Behavior
In Step 5 in Transcoding Framerate you should see something like 200 FPS (8.33)
Screenshots
System (please complete the following information):
The text was updated successfully, but these errors were encountered: