Fix missing transcoding speed info #6199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
nyanmisaka
reviewed
Oct 14, 2024
thornbill
changed the title
|
thornbill
approved these changes
Nov 1, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Nov 3, 2024
Fix missing transcoding speed info Original-merge: 6d37cfc Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the MediaInfoItem
jellyfin-web/src/components/itemMediaInfo/itemMediaInfo.js
Lines 131 to 133 in 39ec804
stream.AverageFrameRate || stream.RealFrameRate. However in the Playback Info Widget onlyvideoStream.AverageFrameRateis used. This results in the Playback Info Widget not showing how much faster the transcoding process is compared to the original frames per seconds.Changes
To also use the RealFrameRate in
getDisplayTranscodeFps, in case the AverageFrameRate is null.Issues
Fixes #6198