Change encoding preset and play stats for server change #6043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanmisaka
approved these changes
Sep 9, 2024
| // label: globalize.translate('LabelHardwareEncoding'), | ||
| // value: session.TranscodingInfo.HardwareAccelerationType | ||
| // }); | ||
| // } |
There was a problem hiding this comment.
Actually you can just delete it. This field has little value to the user.
If anyone is interested in this field, it must be admin. Looking at ffmpeg logs or gpu-top is much more accurate than this.
|
Cloudflare Pages deployment
|
soultaco83
added a commit
to soultaco83/jellyfin-web-requeststab
that referenced
this pull request
Sep 15, 2024
thornbill
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The hardware acceleration type currently only reflects the configuration in the dashboard, without accounting for potential software fallback and/or situations like QSV interop with VAAPI. This can result in displaying that a hardware encoder of certain type is in use when it's actually not. In 10.9 and earlier, we did not display this field due to an enum type mismatch. However, this issue has been fixed on the server side, causing the field to now appear, though with inaccurate data. We need to hide that until the server refactored the transcoding pipeline so that the actual encoder can be reported.
Issues
Changes made for jellyfin/jellyfin#12561
Fixes jellyfin/jellyfin#12630