Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change encoding preset and play stats for server change #6043

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Change encoding preset and play stats for server change #6043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49ae4c3
FIx auto preset in enum
gnattu Sep 9, 2024
db972f8
Hide hardware acceleration type in playstats
gnattu Sep 9, 2024
2a522f7
Fix none hwaccel
gnattu Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/components/playerstats/playerstats.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,17 @@ function getTranscodingStats(session, player, displayPlayMethod) {
value: session.TranscodingInfo.TranscodeReasons.map(translateReason).join('<br/>')
});
}
if (session.TranscodingInfo.HardwareAccelerationType) {
sessionStats.push({
label: globalize.translate('LabelHardwareEncoding'),
value: session.TranscodingInfo.HardwareAccelerationType
});
}
// Hide this for now because it is not useful in its current state.
// This only reflects the configuration in the dashboard, but the actual
// decoder/encoder selection is more complex. As a result, the hardware
// encoder may not be used even if hardware acceleration is configured,
// making the display of hardware acceleration misleading.
// if (session.TranscodingInfo.HardwareAccelerationType) {
// sessionStats.push({
// label: globalize.translate('LabelHardwareEncoding'),
// value: session.TranscodingInfo.HardwareAccelerationType
// });
// }
Copy link
Member

@nyanmisaka nyanmisaka Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you can just delete it. This field has little value to the user.

If anyone is interested in this field, it must be admin. Looking at ffmpeg logs or gpu-top is much more accurate than this.

}

return sessionStats;
Expand Down
4 changes: 2 additions & 2 deletions src/controllers/dashboard/encodingsettings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ <h2 class="sectionTitle">${Transcoding}</h2>

<div class="selectContainer">
<select is="emby-select" id="selectVideoDecoder" label="${LabelHardwareAccelerationType}">
<option value="">${None}</option>
<option value="none">${None}</option>
<option value="amf">AMD AMF</option>
<option value="nvenc">Nvidia NVENC</option>
<option value="qsv">Intel QuickSync (QSV)</option>
Expand Down Expand Up @@ -312,7 +312,7 @@ <h3 class="checkboxListLabel">${LabelEncodingFormatOptions}</h3>

<div class="selectContainer">
<select is="emby-select" id="selectEncoderPreset" label="${LabelEncoderPreset}">
<option value="">${Auto}</option>
<option value="auto">${Auto}</option>
<option value="veryslow">veryslow</option>
<option value="slower">slower</option>
<option value="slow">slow</option>
Expand Down
Loading