Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up the Docker image library to create/push tags at the same time for both GH and Docker (instead of running additional build) #3751

Open
smerle33 opened this issue Sep 12, 2023 · 2 comments

Comments

@smerle33
Copy link
Contributor

smerle33 commented Sep 12, 2023

Service(s)

infra.ci.jenkins.io

Summary

following jenkins-infra/pipeline-library#730

we can now build and publish the image in docker from main and the tag in one pass to save some power and avoid one pass in main and then on the github tag.

Reproduction steps

No response

@smerle33 smerle33 added the triage Incoming issues that need review label Sep 12, 2023
@smerle33 smerle33 removed the triage Incoming issues that need review label Sep 15, 2023
@smerle33 smerle33 added this to the infra-team-sync-2023-09-19 milestone Sep 15, 2023
@smerle33 smerle33 self-assigned this Sep 15, 2023
@smerle33
Copy link
Contributor Author

smerle33 commented Sep 15, 2023

Proposal :
change call to parallelDockerUpdatecli when automaticSemanticVersioning: true and main branch then publish as latest AND tag. Remove build as tag but keep the github tagging

Problem: how to handle manual tag and still not build on automatic tag from the pipeline library ?

@dduportal
Copy link
Contributor

Problem: how to handle manual tag and still not build on automatic tag from the pipeline library ?

By "handle manual tag" I assume you mean "When manually creating a tag in the GitHub repository"?

In any cases, we'll have to disable the "automatic build trigger" rule in infra.ci.jenkins: this rule usually says "when you discover a tag, then trigger a build automatically on the git reference pointed by this tag unless it is older than 3 days". It is configured as a custom "build strategy" defined in JobDSL template here: https://github.com/jenkins-infra/helm-charts/blob/436ec843b49a0dea1088bb00388a9469f94a7b40/charts/jenkins-jobs/templates/_helpers.tpl#L168-L188.

=> We will have to disable this to allow your change to work at first, to stop build being triggered each time a tag is pushed.

Next step: we'll have to decide if we also keep discovering tags in infra.ci. I believe we should not, but in that case we have to find a solution to NOT remove the builds of the main branch which led to a release (e.g... all) or at least keep them longer than today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants