breaking!(buildDockerAndPublishImage): support multi-platform with Docker Bake for building Linux container images #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds good : 
|
dduportal
reviewed
Aug 25, 2023
dduportal
reviewed
Aug 25, 2023
dduportal
reviewed
Aug 25, 2023
dduportal
reviewed
Aug 25, 2023
dduportal
reviewed
Aug 25, 2023
smerle33
added a commit
to smerle33/docker-inbound-agents
that referenced
this pull request
Aug 29, 2023
|
last successful build for wiki with this PR : https://infra.ci.jenkins.io/job/docker-jobs/job/docker-confluence-data/job/PR-48/63/pipeline-graph/ |
dduportal
requested changes
Aug 30, 2023
There was a problem hiding this comment.
First pass of review:
- You have to update the documentation of the method (both
README.mdand the txt file) - You have to update the PR title and body
- There are missing unit tests for some if / WARNING
- A few code discussion (removal of untested or untestable code, a few suggestions on comments, code style and naming conventions)
It is a great job, the code looks really nice! 👏
The end to end tests are good and shows that the intent work!
smerle33
changed the title
dduportal
reviewed
Aug 30, 2023
dduportal
reviewed
Aug 30, 2023
dduportal
approved these changes
Aug 31, 2023
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per jenkins-infra/helpdesk#3619
provide the ability to build docker images for multi platforms as linux/arm64, linux/amd64 etc ...
this use the bake mode to directly build multiplatform.
It also convert "normal" one platform build for linux as docker bake build in buildx engine.
BREAKING CHANGES :
makefileparameterIMAGE_PLATFORMchange forBUILD_TARGETPLATFORMplatformchange fortargetplatforms(the deprecated parameter is still consume for now)