Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking!(buildDockerAndPublishImage): support multi-platform with Docker Bake for building Linux container images (v2) #739

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Sep 1, 2023

the commit 49bb389 revert back #738 to #730

with the null tag_name correction here f959b6f

and 8a82239 allow to specify a docker tag when deploying windows container on git tag trigger

@smerle33 smerle33 changed the title Dockerbake v2 breaking!(buildDockerAndPublishImage): support multi-platform with Docker Bake for building Linux container images (v2) Sep 1, 2023
@smerle33 smerle33 marked this pull request as ready for review September 1, 2023 12:32
@smerle33 smerle33 requested review from a team and dduportal September 1, 2023 12:32
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reverted the revert ✅
  • We paired on the 2 bug fixes

Let's roll by testing a new image build!

@dduportal dduportal merged commit 21d593a into jenkins-infra:master Sep 1, 2023
3 checks passed
@smerle33 smerle33 deleted the dockerbake-v2 branch September 7, 2023 13:48
smerle33 added a commit to smerle33/pipeline-library that referenced this pull request Jan 16, 2024
…cker Bake for building Linux container images (v2) (jenkins-infra#739)

* Revert "Revert "breaking!(buildDockerAndPublishImage): support multi-platform with Docker Bake for building Linux container images""

This reverts commit 20a7e6b.

* fix(buildDockerAndPublishImage): remove Env TAG_NAME useless and unitest test that were only testing test

* fix(buildDockerAndPublishImage): specify docker tag when deploying windows container on git tag trigger

* chore(BuildDockerAndPublishImage): change unit test to simulate windows shell

* chore(BuildDockerAndPublishImage): change unit test to use real life windows target platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants