Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports changes from weekly to LTS 2.332 line #248

Merged
merged 33 commits into from
Jun 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
075401a
Update LTS release checklist (#224)
cathychan Mar 9, 2022
aaf8596
chore: replace git.io link (#230)
lemeurherve Apr 26, 2022
1f62526
Correct minor typo in README (#235)
MarkEWaite May 23, 2022
1979e85
Call to rollback would fail due to wrong name (#234)
MarkEWaite May 23, 2022
faee358
Release signed remoting from stable-4.13.x branch, not master branch
MarkEWaite May 23, 2022
565ff94
Add a clarifying comment
MarkEWaite May 23, 2022
6669fee
Merge pull request #236 from MarkEWaite/release-remoting-from-stable-…
MarkEWaite May 23, 2022
5a2c2af
Update packaging image (#237)
timja Jun 7, 2022
1b1cea4
[updatecli] Bump jenkinsciinfra/packaging Docker image version (#232)
github-actions[bot] Jun 7, 2022
c537f73
fix(release) Rely on the Docker image `PATH` to locate the default `j…
dduportal Jun 7, 2022
c53819d
fix(package) use a recent remoting version
dduportal Jun 7, 2022
5c99602
Merge pull request #238 from jenkins-infra/fix/weekly-20220607
dduportal Jun 7, 2022
520e997
fix(release) use openssl legacy provider for pkcs12
dduportal Jun 7, 2022
66a016e
Update release.bash
dduportal Jun 7, 2022
927a487
Merge pull request #239 from jenkins-infra/hotfix/pkcs12-cipher
dduportal Jun 7, 2022
d220df7
Display Maven version information without stopping build
basil Jun 7, 2022
d12679f
Merge pull request #240 from basil/version
MarkEWaite Jun 7, 2022
dd8d557
chore: Update key "spec.containers[0].image" from file "/tmp/updatecl…
github-actions[bot] Jun 7, 2022
ae4fe7a
chore: Update key "spec.containers[0].image" from file "/tmp/updatecl…
github-actions[bot] Jun 7, 2022
0c25b81
Merge pull request #241 from jenkins-infra/updatecli_597129cc9fe6e19e…
dduportal Jun 7, 2022
4b706e9
Generate resources while staging release (#242)
timja Jun 7, 2022
7470cab
Change `generate-resources` to `compile` (#243)
timja Jun 8, 2022
f999069
Revert generate-resources / compile (#244)
timja Jun 8, 2022
9b46f53
chore: Update key "spec.containers[0].image" from file "/tmp/updatecl…
github-actions[bot] Jun 9, 2022
5ca97b2
chore: Update key "spec.containers[0].image" from file "/tmp/updatecl…
github-actions[bot] Jun 9, 2022
22d2893
Update release
dduportal Jun 9, 2022
9d96da0
Update package
dduportal Jun 9, 2022
0c011dc
Update package
dduportal Jun 9, 2022
acab202
Update stable
dduportal Jun 9, 2022
7f1f3a1
Update stable-rc
dduportal Jun 9, 2022
423f3a6
Update weekly
dduportal Jun 9, 2022
c912345
Merge pull request #247 from jenkins-infra/chore/helpdesk-2979
dduportal Jun 9, 2022
e5a8e1f
Merge pull request #246 from jenkins-infra/updatecli_597129cc9fe6e19e…
dduportal Jun 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/1-lts-release-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ This role should rotate between LTS releases

- [ ] Merge backporting PR in jenkinci/jenkins using a merge commit (do not squash)

- [ ] Retrieve the url for the RC from the commit status (continuous-integration/jenkins/incrementals) of the last build on the stable branch (requires a passing build). You will get something like https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/cli/2.303.2-rc31385.6eec6c02fc3d/, replace `cli` with `jenkins-war`, visit the page and copy the URL to the war file, for the earlier example it would be https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.303.2-rc31385.6eec6c02fc3d/jenkins-war-2.303.2-rc31385.6eec6c02fc3d.war. If incrementals are broken you can deploy a build from your own machine with `mvn -e clean deploy -DskipTests=true`.
- [ ] Retrieve the url for the RC from the commit status (Jenkins Incrementals Publisher / Incrementals) of the last build on the stable branch (requires a passing build). Visit the `jenkins-war` URL and copy the URL of the war file, which would be something like https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.303.2-rc31385.6eec6c02fc3d/jenkins-war-2.303.2-rc31385.6eec6c02fc3d.war. If incrementals are broken you can deploy a build from your own machine with `mvn -e clean deploy -DskipTests=true`.

- [ ] Publish a pre-release [Github release](https://github.com/jenkinsci/jenkins/releases), e.g. [sample](https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.289.2-rc) currently we don't have a changelog for RCs

Expand Down Expand Up @@ -94,4 +94,4 @@ This role should rotate between LTS releases

- [ ] Confirm that the images are available at [Docker hub](https://hub.docker.com/r/jenkins/jenkins/tags)

- [ ] [Update ci.jenkins.io](https://github.com/jenkins-infra/runbooks/tree/master/ci#upgrading-jenkins) to the new LTS release (note: repo is private, requires infra team membership)
- [ ] Create a [helpdesk](https://github.com/jenkins-infra/helpdesk/issues) ticket to update `ci.jenkins.io`, `trusted.ci`, `cert.ci` and `release.ci` to the new LTS release, [example](https://github.com/jenkins-infra/helpdesk/issues/2816)
4 changes: 1 addition & 3 deletions Jenkinsfile.d/core/package
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
pipeline {
agent {
kubernetes {
label 'package-linux'
yamlFile 'PodTemplates.d/package-linux.yaml'
workingDir '/home/jenkins/agent'
}
Expand All @@ -15,7 +14,7 @@ pipeline {
'stable-rc',
'security'
],
description: 'Define which Jenkins Release we are packaging for. https://git.io/Jv7Nr',
description: 'Define which Jenkins Release we are packaging for. https://github.com/jenkins-infra/release/tree/master/profile.d',
name: 'RELEASE_PROFILE'
)
string(
Expand Down Expand Up @@ -256,7 +255,6 @@ pipeline {
// as the step 'container' is known to not be working
agent {
kubernetes {
label 'packaging-windows'
yamlFile 'PodTemplates.d/package-windows.yaml'
}
}
Expand Down
3 changes: 1 addition & 2 deletions Jenkinsfile.d/core/release
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
pipeline {
agent {
kubernetes {
label 'release-linux'
yamlFile 'PodTemplates.d/release-linux.yaml'
}
}
Expand All @@ -22,7 +21,7 @@ pipeline {
'stable-rc',
'weekly'
],
description: 'Define which release profile we are going to use. https://git.io/Jv7Nr',
description: 'Define which release profile we are going to use. https://github.com/jenkins-infra/release/tree/master/profile.d',
name: 'RELEASE_PROFILE'
)
string(
Expand Down
1 change: 0 additions & 1 deletion Jenkinsfile.d/core/stable
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ pipeline {

agent {
kubernetes {
label 'release-stable'
}
}

Expand Down
1 change: 0 additions & 1 deletion Jenkinsfile.d/core/stable-rc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ pipeline {

agent {
kubernetes {
label 'release-stable-rc'
}
}

Expand Down
1 change: 0 additions & 1 deletion Jenkinsfile.d/core/weekly
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ pipeline {

agent {
kubernetes {
label 'release-weekly'
}
}

Expand Down
2 changes: 1 addition & 1 deletion PodTemplates.d/package-linux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
spec:
containers:
- name: jnlp
image: jenkinsciinfra/packaging:2.1.9
image: jenkinsciinfra/packaging:2.1.41
imagePullPolicy: "IfNotPresent"
env:
- name: "HOME"
Expand Down
2 changes: 1 addition & 1 deletion PodTemplates.d/package-windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ metadata:
jenkins/default-release-jenkins-agent: true
spec:
containers:
- image: "jenkins/inbound-agent:4.3-9-windowsservercore-1809"
- image: "jenkins/inbound-agent:4.13-2-jdk11-nanoserver-1809"
imagePullPolicy: "Always"
name: "jnlp"
resources:
Expand Down
4 changes: 1 addition & 3 deletions PodTemplates.d/release-linux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@ metadata:
spec:
containers:
- name: jnlp
image: jenkinsciinfra/packaging:2.1.9
image: jenkinsciinfra/packaging:2.1.41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a backport of jenkinsci/jenkins#6628 to 2.332 and 2.346

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this change be (partially) reverted instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packaging branch will also need merging then

I'm not aware of any packaging branch, what are you refering to?

https://github.com/jenkinsci/packaging/branches

Could this change be (partially) reverted instead?

Yes it would just need this version bump reverted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hop: #252

imagePullPolicy: "IfNotPresent"
env:
- name: "HOME"
value: "/home/jenkins/agent/workspace"
- name: "MAVEN_OPTS"
value: "-Xmx8g -Xms8g"
- name: "JENKINS_JAVA_BIN"
value: "/opt/jdk-11/bin/java"
resources:
limits:
memory: "16Gi"
Expand Down
2 changes: 1 addition & 1 deletion README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ At this stage, we are going to retrieve the Java code, release a new version usi
It's important to notice that we do not use the maven release plugin to checkout git repositories neither to push changes. This allow us to release from a different git repository than the one defined in the pom.xml. We also need to be able to push commits to a different repository than the one defined in the pom.xml.

. link:http://maven.apache.org/maven-release/maven-release-plugin/perform-mojo.html#localCheckout[localCheckout] must be set to true
. link:http://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#pushChanges[puchChanges] must be set to false
. link:http://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#pushChanges[pushChanges] must be set to false


==== Steps
Expand Down
3 changes: 2 additions & 1 deletion profile.d/components/remoting
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
RELEASE_GIT_BRANCH=master
# Releases from the master branch now use JEP-229, not this release process
RELEASE_GIT_BRANCH=stable-4.13.x
RELEASE_GIT_REPOSITORY=git@github.com:jenkinsci/remoting.git
GIT_EMAIL=66998184+jenkins-release-bot@users.noreply.github.com
GIT_NAME="Jenkins Release Bot"
Expand Down
13 changes: 10 additions & 3 deletions utils/release.bash
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ function configureKeystore(){
case "$SIGN_CERTIFICATE" in
*.pem )
openssl pkcs12 -export \
-legacy `# https://github.com/openssl/openssl/issues/11672` \
-out "$SIGN_KEYSTORE" \
-in "${SIGN_CERTIFICATE}" \
-password "pass:$SIGN_STOREPASS" \
Expand All @@ -85,8 +86,14 @@ function configureKeystore(){
*.pfx )
# pfx file download from azure key vault are not password protected, which is required for maven release plugin
# so we need to add a new password
openssl pkcs12 -in "${SIGN_CERTIFICATE}" -out tmpjenkins.pem -nodes -passin pass:""
openssl pkcs12 \
-in "${SIGN_CERTIFICATE}" \
-legacy `# https://github.com/openssl/openssl/issues/11672` \
-out tmpjenkins.pem \
-nodes \
-passin pass:""
openssl pkcs12 -export \
-legacy `# https://github.com/openssl/openssl/issues/11672` \
-out "$SIGN_KEYSTORE" \
-in tmpjenkins.pem \
-password "pass:$SIGN_STOREPASS" \
Expand Down Expand Up @@ -429,7 +436,7 @@ function stageRelease(){
# 2020-06-24: --no-transfer-progress doesn't seem to be fully suported in maven release plugin
# This workaround can be reverted once MRELEASE-1048 is fixed
# https://issues.apache.org/jira/browse/MRELEASE-1048
mvn -B \
mvn -V -B \
"-DstagingRepository=${MAVEN_REPOSITORY_NAME}::default::${MAVEN_REPOSITORY_URL}/${MAVEN_REPOSITORY_NAME}" \
-s settings-release.xml \
--no-transfer-progress \
Expand Down Expand Up @@ -567,7 +574,7 @@ function main(){
--showPackagingPlan) echo "Show Packaging Plan" && showPackagingPlan ;;
--promoteStagingMavenArtifacts) echo "Promote Staging Maven Artifacts" && promoteStagingMavenArtifacts ;;
--promoteStagingGitRepository) echo "Promote Staging Git Repository" && promoteStagingGitRepository ;;
--rollback) echo "Rollback release $RELEASE_SCM_TAG" && rollblack ;;
--rollback) echo "Rollback release $RELEASE_SCM_TAG" && rollback ;;
--stageRelease) echo "Stage Release" && stageRelease ;;
--packaging) echo 'Execute packaging makefile, quote required around Makefile target' && packaging "$2";;
--syncMirror) echo 'Trigger mirror synchronization' && syncMirror ;;
Expand Down