Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jx boot failing on GHE with latest CLI due to failing GET request #6551

Closed
1 of 2 tasks
tomfrenken opened this issue Jan 17, 2020 · 3 comments · Fixed by #6574
Closed
1 of 2 tasks

jx boot failing on GHE with latest CLI due to failing GET request #6551

tomfrenken opened this issue Jan 17, 2020 · 3 comments · Fixed by #6574
Assignees
Labels
Milestone

Comments

@tomfrenken
Copy link

Summary

With the latest CLI I receive the following errors on GitHub Enterprise:

error: handle dev environment repository: creating remote for dev environment environment-jx-eval-01-dev: duplicating https://github.com/tomfrenken/jenkins-x-boot-config to jx-test-org/environment-jx-eval-01-dev: getting repo for https://github.com/tomfrenken/jenkins-x-boot-config: failed to get repository tomfrenken/jenkins-x-boot-config due to: GET https://github.tools.sap/api/v3/repos/tomfrenken/jenkins-x-boot-config: 404 Not Found []
error: failed to interpret pipeline file jenkins-x.yml: failed to run '/bin/sh -c jx step verify env' command in directory '.', output: ''

I previously forked the repo and changed the files, the jx-requirements.yaml looks like this:

cluster:
  clusterName: ""
  environmentGitOwner: ""
  environmentGitPublic: false
  gitKind: github
  gitName: ghe
  gitServer: https://github.tools.sap
  project: ""
  provider: gke
  zone: ""
gitops: true
environments:
- key: dev
- key: staging
- key: production
ingress:
  domain: ""
  externalDNS: false
  tls:
    email: ""
    enabled: false
    production: false
kaniko: true
secretStorage: local
storage:
  logs:
    enabled: true
    url: ""
  reports:
    enabled: true
    url: ""
  repository:
    enabled: true
    url: ""
versionStream:
  ref: "master"
  url: https://github.com/jenkins-x/jenkins-x-versions.git
webhook: lighthouse

Steps to reproduce the behavior

Fork the boot-config, change values to work with GHE, run jx boot

Expected behavior

It works

Actual behavior

It doesn't

Jx version

The output of jx version is:

NAME               VERSION
jx                 2.0.1133
Kubernetes cluster v1.13.11-gke.14
kubectl            v1.17.1
helm client        Client: v2.16.1+gbbdfe5e
git                2.25.0
Operating System   Mac OS X 10.15.2 build 19C57

Jenkins type

  • Serverless Jenkins X Pipelines (Tekton + Lighthouse)
  • Classic Jenkins
@abayer
Copy link
Contributor

abayer commented Jan 20, 2020

I rewrote this logic again in 2.0.1134 - mind giving it another try? That said, I have a feeling something else may blow up after this point. I’m gradually struggling my way through getting boot + gitops actually working with non github.com providers, and there are a surprising number of little gotchas.

@tomfrenken
Copy link
Author

Sure I'll try it in a few hours again 👍

@abayer abayer self-assigned this Jan 21, 2020
@abayer abayer added area/boot issues in the `jx boot` command area/git-providers kind/bug Issue is a bug priority/important-longterm labels Jan 21, 2020
@abayer
Copy link
Contributor

abayer commented Jan 21, 2020

So we actually nailed this one down last night - the bootConfigURL was set to a non-default repo on github.com, so it slipped through my logic for not using the default provider. I will fix. =)

abayer added a commit to abayer/jx that referenced this issue Jan 21, 2020
The specific issue prompting this was a GHE user with a custom boot
config upstream forked in github.com. That slipped through, since we
were specifically looking for cases where the destination wasn't
github.com and the origin was the default boot config repository, but
when I think about it more, it makes more sense to just fall back to
the simpler non-provider-driven approach to the origin for all cases
where the git host for the origin and destination repository URLs differ.

fixes jenkins-x#6551

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer added this to the Sprint 1 2020 milestone Jan 21, 2020
jenkins-x-bot pushed a commit that referenced this issue Jan 21, 2020
The specific issue prompting this was a GHE user with a custom boot
config upstream forked in github.com. That slipped through, since we
were specifically looking for cases where the destination wasn't
github.com and the origin was the default boot config repository, but
when I think about it more, it makes more sense to just fall back to
the simpler non-provider-driven approach to the origin for all cases
where the git host for the origin and destination repository URLs differ.

fixes #6551

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
daveconde pushed a commit to daveconde/jx that referenced this issue Apr 7, 2020
The specific issue prompting this was a GHE user with a custom boot
config upstream forked in github.com. That slipped through, since we
were specifically looking for cases where the destination wasn't
github.com and the origin was the default boot config repository, but
when I think about it more, it makes more sense to just fall back to
the simpler non-provider-driven approach to the origin for all cases
where the git host for the origin and destination repository URLs differ.

fixes jenkins-x#6551

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants