-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jx boot
failing on GHE with latest CLI due to failing GET request
#6551
Comments
I rewrote this logic again in 2.0.1134 - mind giving it another try? That said, I have a feeling something else may blow up after this point. I’m gradually struggling my way through getting boot + gitops actually working with non github.com providers, and there are a surprising number of little gotchas. |
Sure I'll try it in a few hours again 👍 |
So we actually nailed this one down last night - the |
The specific issue prompting this was a GHE user with a custom boot config upstream forked in github.com. That slipped through, since we were specifically looking for cases where the destination wasn't github.com and the origin was the default boot config repository, but when I think about it more, it makes more sense to just fall back to the simpler non-provider-driven approach to the origin for all cases where the git host for the origin and destination repository URLs differ. fixes jenkins-x#6551 Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
The specific issue prompting this was a GHE user with a custom boot config upstream forked in github.com. That slipped through, since we were specifically looking for cases where the destination wasn't github.com and the origin was the default boot config repository, but when I think about it more, it makes more sense to just fall back to the simpler non-provider-driven approach to the origin for all cases where the git host for the origin and destination repository URLs differ. fixes #6551 Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
The specific issue prompting this was a GHE user with a custom boot config upstream forked in github.com. That slipped through, since we were specifically looking for cases where the destination wasn't github.com and the origin was the default boot config repository, but when I think about it more, it makes more sense to just fall back to the simpler non-provider-driven approach to the origin for all cases where the git host for the origin and destination repository URLs differ. fixes jenkins-x#6551 Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Summary
With the latest CLI I receive the following errors on GitHub Enterprise:
I previously forked the repo and changed the files, the
jx-requirements.yaml
looks like this:Steps to reproduce the behavior
Fork the boot-config, change values to work with GHE, run
jx boot
Expected behavior
It works
Actual behavior
It doesn't
Jx version
The output of
jx version
is:Jenkins type
The text was updated successfully, but these errors were encountered: