fix: Fall back to not using provider for dev env creation in more cases #6574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specific issue prompting this was a GHE user with a custom boot config upstream forked in github.com. That slipped through, since we were specifically looking for cases where the destination wasn't github.com and the origin was the default boot config repository, but when I think about it more, it makes more sense to just fall back to the simpler non-provider-driven approach to the origin for all cases where the git host for the origin and destination repository URLs differ. fixes jenkins-x#6551 Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hferentschik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter checklist
Description
The specific issue prompting this was a GHE user with a custom boot config upstream forked in github.com. That slipped through, since we were specifically looking for cases where the destination wasn't github.com and the origin was the default boot config repository, but when I think about it more, it makes more sense to just fall back to the simpler non-provider-driven approach to the origin for all cases where the git host for the origin and destination repository URLs differ.
Special notes for the reviewer(s)
Which issue this PR fixes
fixes #6551