Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed build logs not properly storing in buckets #7461

Closed
abayer opened this issue Jul 20, 2020 · 0 comments · Fixed by #7462
Closed

Completed build logs not properly storing in buckets #7461

abayer opened this issue Jul 20, 2020 · 0 comments · Fixed by #7462
Assignees
@abayer
Labels
area/logs kind/bug Issue is a bug priority/critical ready-for-review

Comments

@abayer
Copy link
Contributor

abayer commented Jul 20, 2020

Seems to be since #7429 went in - in the build controller, we now see things like:

{"level":"info","msg":"storing logs for activity jenkins-x-jx-master-970 into storage at jenkins-x/logs/jenkins-x/jx/master/970.log","time":"2020-07-20T12:51:19Z"}
{"level":"error","msg":"failed to store logs for activity jenkins-x-jx-master-970 into storage at jenkins-x/logs/jenkins-x/jx/master/970.log: failed to write key jenkins-x/logs/jenkins-x/jx/master/970.log in bucket gs://logs-oss-weasel-e5201f35d164: short write","time":"2020-07-20T12:51:24Z"}
{"level":"warning","msg":"failed to write key jenkins-x/logs/jenkins-x/jx/master/970.log in bucket gs://logs-oss-weasel-e5201f35d164: short write","time":"2020-07-20T12:51:24Z"}

Not sure what went wrong there, but something's definitely awry.
@abayer abayer self-assigned this Jul 20, 2020
@abayer abayer mentioned this issue Jul 20, 2020
Merged
2 tasks
abayer added a commit to abayer/jx that referenced this issue Jul 20, 2020
@abayer
fix: Read the entire reader before writing to bucket
2bd412a 
For some reason, `io.Copy` was resulting in a "short write" error in
the build controller, and the best suspicion I've got at this point is
that it's a problem with the bucket writer closing early or something
along those lines. So let's instead go back to earlier behavior and
read the reader contents and write that directly rather than relying
on `io.Copy`.

fixes jenkins-x#7461 (hopefully!)

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
jenkins-x-bot pushed a commit that referenced this issue Jul 20, 2020
@abayer @jenkins-x-bot
fix: Read the entire reader before writing to bucket
c47ce72 
For some reason, `io.Copy` was resulting in a "short write" error in
the build controller, and the best suspicion I've got at this point is
that it's a problem with the bucket writer closing early or something
along those lines. So let's instead go back to earlier behavior and
read the reader contents and write that directly rather than relying
on `io.Copy`.

fixes #7461 (hopefully!)

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abayer abayer

Labels
area/logs kind/bug Issue is a bug priority/critical ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Read the entire reader before writing to bucket abayer/jx
1 participant
@abayer