refactor: improve build log stream #7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 7, 2020
houndci-bot
reviewed
Jul 7, 2020
mgoltzsche
force-pushed
the
fix_build_log_stream
branch
from
5fdd1e4 to
c7c8176
Compare
abayer
reviewed
Jul 7, 2020
mgoltzsche
force-pushed
the
fix_build_log_stream
branch
3 times, most recently
from
8b3d387 to
d2d4e1c
Compare
mgoltzsche
force-pushed
the
fix_build_log_stream
branch
4 times, most recently
from
0ad26b1 to
bf752fa
Compare
improvements: * let build log methods return channel to let the caller handle streamed log lines within its own goroutine. * stream build log to long-term storage. * change storage provider interface to stream data. Closes jenkins-x#7422 Signed-off-by: Max Goltzsche <mgoltzsche@cloudbees.com>
mgoltzsche
force-pushed
the
fix_build_log_stream
branch
from
bf752fa to
e13cc93
Compare
mgoltzsche
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abayer
added a commit
to abayer/jx
that referenced
this pull request
Jul 20, 2020
For some reason, `io.Copy` was resulting in a "short write" error in the build controller, and the best suspicion I've got at this point is that it's a problem with the bucket writer closing early or something along those lines. So let's instead go back to earlier behavior and read the reader contents and write that directly rather than relying on `io.Copy`. fixes jenkins-x#7429 (hopefully!) Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
handle streamed log lines within its own goroutine.
Closes #7422
Submitter checklist
Description
improve build log stream
Special notes for the reviewer(s)
Which issue this PR fixes
fixes #7422