Commit / tag on failure #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also shows names as well as IDs in the Build Data section Code by @djl197 I just merged it onto a more current master
Closed
|
It doesn't cover all use cases, job status can be also Unstable. Some hetero list with dropdown cases should resolve it more dynamic and modular instead hardcoded checkboxes. |
|
Yep - this would be good (something we've found we need too, where a unit test fails it'd still be nice to pull the container to figure out why). |
|
Yep. Selecting a threshold or a multi-select box to cover all cases is a much better idea. |
| @@ -73,6 +81,7 @@ public boolean isApplicable(Class<? extends Job> jobType) { | |||
| public DockerJobProperty newInstance(StaplerRequest sr, JSONObject formData) throws hudson.model.Descriptor.FormException { | |||
| return new DockerJobProperty( | |||
| (Boolean)formData.get("tagOnCompletion"), | |||
| (Boolean)formData.get("tagOnFailure"), | |||
There was a problem hiding this comment.
Why not use getBoolean method?
|
#181 related |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also shows names as well as IDs in the Build Data section
Code by @djl197 I just merged it onto a more current master