add options to push container on unstable/failed builds #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
My guess #132 (comment) was right :) |
|
👍 |
|
This feature would be useful for debugging. e.g. temporarily enable pushing failed images to debug and then disable it when done. I remember a time when I needed this. I got around it in other non-intuitive ways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two options to push the container at the end of a build in case the build is unstable or the build fails.
This changes the original behavior, the original push if successful check box triggered a push even if the build failed.
I use these new flags to store the builds for inspection on our private docker registry in case of test or build failures.
This merge request implements #91.