Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen on loopback interface by default in debug mode #4515

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

daniel-beck
Copy link
Member

Local development setups usually don't need to listen on all interfaces, so restrict to localhost by default when running mvn jetty:run.

Apparently host is the Jetty terminology for the listen address, so use that for the property.
I didn't want to think about IPv4/IPv6, so use localhost instead of e.g. 127.0.0.1. JenkinsRule uses localhost as well.

Restore previous behavior by setting -Dhost=0.0.0.0 on the command line.

Corresponding PR in Maven HPI Plugin at jenkinsci/maven-hpi-plugin#169.

Proposed changelog entries

Too minor? Unsure.

Proposed upgrade guidelines

N/A

Submitter checklist

  • [n/a] JIRA issue is well described
  • [n/a] Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

@timja timja added the skip-changelog Should not be shown in the changelog label Feb 22, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to merge it tomorrow if no negative feedback

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 24, 2020
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too minor? Unsure.

I am more in favor of having a line on the changelog. It could be useful to developer using this "feature" in their environment to find when it was added and especially the workaround.

Otherwise the PRs themselves seem fine 👍

@oleg-nenashev oleg-nenashev added developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog labels Feb 25, 2020
@oleg-nenashev
Copy link
Member

Since all of us agree in principle, 🚢 🇮🇹 . We can discuss the changelog in the background

@oleg-nenashev oleg-nenashev merged commit f5f4ca4 into jenkinsci:master Feb 25, 2020
@timja
Copy link
Member

timja commented Feb 28, 2020

This broke my local developer setup,

macOS Catalina

Errors were:
This page isn’t workinglocalhost didn’t send any data.
ERR_EMPTY_RESPONSE

and
Sometimes:
ERR_SOCKET_NOT_CONNECTED

I've found that it will works for me if I access jenkins via:
http://127.0.0.1:8080/jenkins

I was previously using:
http://localhost:8080/jenkins

@timja
Copy link
Member

timja commented Feb 28, 2020

-Dhost=0.0.0.0 doesn't revert to the previous behaviour, I still can't access it with localhost

@timja
Copy link
Member

timja commented Feb 29, 2020

Hmm so I was using intellij and it seems for maven properties you don't use VM options, you use the properties section below it, that worked, still not a fix, but at least I can workaround it.

image

@timja
Copy link
Member

timja commented Feb 29, 2020

Grrr, this was my antivirus, Eset Endpoint security, they think they're so cool, let's block port 8080 on localhost,
WTF
webpack/webpack-dev-server#2272 (comment)

olivergondza pushed a commit that referenced this pull request Mar 11, 2020
Listen on loopback interface by default in debug mode

(cherry picked from commit f5f4ca4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants