-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listen on loopback interface by default in debug mode #4515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to merge it tomorrow if no negative feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too minor? Unsure.
I am more in favor of having a line on the changelog. It could be useful to developer using this "feature" in their environment to find when it was added and especially the workaround.
Otherwise the PRs themselves seem fine 👍
Since all of us agree in principle, 🚢 🇮🇹 . We can discuss the changelog in the background |
This broke my local developer setup, macOS Catalina Errors were: and I've found that it will works for me if I access jenkins via: I was previously using: |
|
Grrr, this was my antivirus, Eset Endpoint security, they think they're so cool, let's block port 8080 on localhost, |
Listen on loopback interface by default in debug mode (cherry picked from commit f5f4ca4)
Local development setups usually don't need to listen on all interfaces, so restrict to
localhost
by default when runningmvn jetty:run
.Apparently
host
is the Jetty terminology for the listen address, so use that for the property.I didn't want to think about IPv4/IPv6, so use
localhost
instead of e.g.127.0.0.1
.JenkinsRule
useslocalhost
as well.Restore previous behavior by setting
-Dhost=0.0.0.0
on the command line.Corresponding PR in Maven HPI Plugin at jenkinsci/maven-hpi-plugin#169.
Proposed changelog entries
Too minor? Unsure.
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate