Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen on loopback interface by default #169

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Feb 22, 2020

Local development setups usually don't need to listen on all interfaces, so restrict to localhost by default.

Apparently host is the Jetty terminology for the listen address, so use that here.
I didn't want to think about IPv4/IPv6, so use localhost instead of e.g. 127.0.0.1. JenkinsRule uses localhost as well.

Restore previous behavior by setting -Dhost=0.0.0.0 on the command line.

Corresponding PR in core at jenkinsci/jenkins#4515.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge and ship it. Then I will cut a plugin POM once it is integrated.

@oleg-nenashev oleg-nenashev merged commit 12b3c9b into jenkinsci:master Feb 24, 2020
@oleg-nenashev
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants