Update common-fields_zh_CN.properties #87
Conversation
Sync with jenkinsci/cmakebuilder-plugin@2725c65 Sorry for the confusion
| @@ -9,5 +9,5 @@ Build\ tool=\u6784\u5EFA\u5DE5\u5177 | |||
| Run\ build\ tool=\u8FD0\u884C\u6784\u5EFA\u5DE5\u5177 | |||
| Add\ build\ tool\ invocation=\u6DFB\u52A0\u6784\u5EFA\u5DE5\u5177 | |||
|
|
|||
| CmakeBuilder.build_steps=\u6784\u5EFA\u6B65\u9AA4 | |||
| CmakeBuilder.actual_build_tool=make, ninja, nmake, ... | |||
There was a problem hiding this comment.
Thanks to keeping track this. But there's no good back compatible solution. So I suggest that just keep the old one, then mark them.
There was a problem hiding this comment.
Yes, you will have to keep the old version (Run\ build\ tool=) for backward compatibility and
haave to ADD the new version (CmakeBuilder.build_steps=)
There was a problem hiding this comment.
Please also note that my pull request actually uses
build_steps= and
actual_build_tool= for the property names.
The prefix CmakeBuilder. has been removed since it is already in the package name.
There was a problem hiding this comment.
If I understand correctly, we should keep CmakeBuilder.build_steps instead of removing them. Right? Plus, mark the old ones as stale.
There was a problem hiding this comment.
Yes. Keep both, marke the old ones as stale.
Sync with jenkinsci/cmakebuilder-plugin@2725c65
Sorry for the confusion
Submitter checklist
Desired reviewers
@jenkinsci/chinese-localization-sig