Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common-fields_zh_CN.properties #87

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Update common-fields_zh_CN.properties #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...lugin/src/main/resources/hudson/plugins/cmake/CmakeBuilder/common-fields_zh_CN.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ Build\ tool=\u6784\u5EFA\u5DE5\u5177
Run\ build\ tool=\u8FD0\u884C\u6784\u5EFA\u5DE5\u5177
Add\ build\ tool\ invocation=\u6DFB\u52A0\u6784\u5EFA\u5DE5\u5177

CmakeBuilder.build_steps=\u6784\u5EFA\u6B65\u9AA4
CmakeBuilder.actual_build_tool=make, ninja, nmake, ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to keeping track this. But there's no good back compatible solution. So I suggest that just keep the old one, then mark them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you will have to keep the old version (Run\ build\ tool=) for backward compatibility and
haave to ADD the new version (CmakeBuilder.build_steps=)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also note that my pull request actually uses
build_steps= and
actual_build_tool= for the property names.
The prefix CmakeBuilder. has been removed since it is already in the package name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, we should keep CmakeBuilder.build_steps instead of removing them. Right? Plus, mark the old ones as stale.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Keep both, marke the old ones as stale.

build_steps=\u6784\u5EFA\u6B65\u9AA4
actual_build_tool=make, ninja, nmake, ...