Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReconfigurableOpenTelemetry to the otel api plugin #7

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Add ReconfigurableOpenTelemetry to the otel api plugin #7

merged 1 commit into from
Jul 5, 2024

Conversation

cyrille-leclerc
Copy link
Contributor

@cyrille-leclerc cyrille-leclerc commented Jul 4, 2024 •
edited
Loading

Add ReconfigurableOpenTelemetry to the otel api plugin.

It enables to decouple plugins using OTel like the Junit Result Storage Plugin from the Jenkins OTel Plugin.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@cyrille-leclerc cyrille-leclerc requested a review from a team as a code owner July 4, 2024 21:58
@cyrille-leclerc cyrille-leclerc mentioned this pull request Jul 4, 2024
Merged
6 tasks
@cyrille-leclerc
Copy link
Contributor Author

@kuisathaverat please review

kuisathaverat
kuisathaverat approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@kuisathaverat kuisathaverat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuisathaverat kuisathaverat added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 5, 2024
@cyrille-leclerc cyrille-leclerc merged commit d6b8758 into main Jul 5, 2024
18 checks passed
@cyrille-leclerc cyrille-leclerc deleted the add-reconfigurable-otel branch July 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees
No one assigned
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyrille-leclerc @kuisathaverat