Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ReconfigurableOpenTelemetry to the Jenkins Otel API Plugin #887

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Move ReconfigurableOpenTelemetry to the Jenkins Otel API Plugin #887

merged 5 commits into from
Jul 10, 2024

Conversation

cyrille-leclerc
Copy link
Contributor

@cyrille-leclerc cyrille-leclerc commented Jul 4, 2024 •
edited
Loading

It enables to decouple plugins using OTel like the Junit Result Storage Plugin from the Jenkins OTel Plugin.

Depends on:

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@cyrille-leclerc
Move ReconfigurableOpenTelemetry to the Jenkins Otel API Plugin
e3e67ea 
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
@cyrille-leclerc
Move ReconfigurableOpenTelemetry to the Jenkins Otel API Plugin
5a507df 
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
@cyrille-leclerc
Merge branch 'main' into use-jenkins-otel-api-plugin
dfa34e7 
# Conflicts:
#	src/main/java/io/jenkins/plugins/opentelemetry/init/JvmMonitoringInitializer.java
#	src/main/java/io/jenkins/plugins/opentelemetry/opentelemetry/ReconfigurableOpenTelemetry.java
@cyrille-leclerc
Merge branch 'main' into use-jenkins-otel-api-plugin
234ac1d
@cyrille-leclerc cyrille-leclerc marked this pull request as ready for review July 9, 2024 11:30
@cyrille-leclerc
Fix GlobalOpenTelemetry lifecycle in test
bea11a3 
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
@cyrille-leclerc
Copy link
Contributor Author

Ready for review @kuisathaverat

@kuisathaverat kuisathaverat added the enhancement New feature or request label Jul 10, 2024
@cyrille-leclerc cyrille-leclerc merged commit fe6b821 into main Jul 10, 2024
16 checks passed
@cyrille-leclerc cyrille-leclerc deleted the use-jenkins-otel-api-plugin branch July 10, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyrille-leclerc @kuisathaverat