fix:Change to use 127.0.0.1 instead of localhost in browser launch at end of install

[slide]

Change to use 127.0.0.1 instead of localhost, this fixes https://issues.jenkins.io/browse/JENKINS-41101

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes

[daniel-beck]

Isn't there a dependency on IPv4 for 127.0.0.1? Is that always present on Windows?

I think we implemented the opposite change somewhere else not too long ago.

[slide]

Isn't there a dependency on IPv4 for 127.0.0.1? Is that always present on Windows?

No, IPv4 is not always present (it can be disabled)

I think we implemented the opposite change somewhere else not too long ago.

Do you remember where this was? I'd like to look at the discussion if possible.

[daniel-beck]

jenkinsci/maven-hpi-plugin#169 might be what I thought was the change "not too long ago" (yay memory), but I cannot find what motivated that position specifically.

jenkinsci/jenkins-test-harness#9 was before, but I probably just checked this for consistency/completeness – but FWIW another point for the localhost in acrive use, even though all of these are in non-production environments.

I mean, if I'm wrong here it wouldn't be the first time 😄 What is this change supposed to accomplish? I read the ticket but don't understand it.

[slide]

Honestly, now that I look at the issue again, I think its bogus. Sorry for the cruft.